Christopher Jones wrote: > > Are there any tests for this? Do we really need one?
Moriyoshi > Chris > > Moriyoshi Koizumi wrote: >> moriyoshi Fri May 15 17:02:35 2009 UTC >> >> Modified files: /php-src/ext/standard array.c >> Log: >> * Roll it back then. I wonder if defaulting it to SORT_REGULAR >> would work well >> and I think allowing user-supplied comparator should make more >> sense when it >> comes to objects. >> >> http://cvs.php.net/viewvc.cgi/php-src/ext/standard/array.c?r1=1.477&r2=1.478&diff_format=u >> >> Index: php-src/ext/standard/array.c >> diff -u php-src/ext/standard/array.c:1.477 >> php-src/ext/standard/array.c:1.478 >> --- php-src/ext/standard/array.c:1.477 Fri May 15 16:44:51 2009 >> +++ php-src/ext/standard/array.c Fri May 15 17:02:34 2009 >> @@ -21,7 +21,7 @@ >> >> +----------------------------------------------------------------------+ >> */ >> >> -/* $Id: array.c,v 1.477 2009/05/15 16:44:51 sixd Exp $ */ >> +/* $Id: array.c,v 1.478 2009/05/15 17:02:34 moriyoshi Exp $ */ >> >> #include "php.h" >> #include "php_ini.h" >> @@ -2889,7 +2889,7 @@ >> }; >> struct bucketindex *arTmp, *cmpdata, *lastkept; >> unsigned int i; >> - long sort_type = PHP_SORT_REGULAR; >> + long sort_type = PHP_SORT_STRING; >> >> if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "a|l", >> &array, &sort_type) == FAILURE) { >> return; >> >> >> > -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
