Thank you for the review. Using `send` would make us incompatible with Guzzle and Buzz. It would force php-http's clients to have two methods doing the same thing. So we are more pragmatic here by using `sendRequest`.
About `\Throwable`... Im not sure. I will do some research and make a PR to the specs. Thanks! Den måndag 4 december 2017 kl. 14:44:41 UTC+1 skrev Woody Gilk: > > A couple of notes: > > public function sendRequest($request) > > Could this be made shorter, without losing meaning? > > public function send($request) > > Regarding the exception interfaces: > > interface ClientException extends \Throwable > > Why Throwable instead of Exception or RuntimeException? > > Everything else looks very straight forward! > > -- > Woody Gilk > http://about.me/shadowhand > > On Mon, Dec 4, 2017 at 3:45 AM, Tobias Nyholm <tobias...@gmail.com > <javascript:>> wrote: > >> After some time of carefully reviewing and discussions on Github I want >> to let the mailing list know that we are soon comfortable with how PSR-18 >> looks. We have documented the discussions in the meta document ( >> https://github.com/php-fig/fig-standards/blob/master/proposed/http-client/http-client-meta.md) >> >> >> >> I invite you all to review the PSR and give some feedback. You will find >> the current specification here: >> https://github.com/php-fig/fig-standards/blob/master/proposed/http-client/http-client.md >> >> >> Regards >> >> Tobias Nyholm >> >> -- >> You received this message because you are subscribed to the Google Groups >> "PHP Framework Interoperability Group" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to php-fig+u...@googlegroups.com <javascript:>. >> To post to this group, send email to php...@googlegroups.com >> <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/php-fig/35361389-c53a-4ee4-ac79-195402d9ab14%40googlegroups.com >> >> <https://groups.google.com/d/msgid/php-fig/35361389-c53a-4ee4-ac79-195402d9ab14%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group. To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+unsubscr...@googlegroups.com. To post to this group, send email to php-fig@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/eb8cf965-ad99-4170-befc-8231ff190b13%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
