On Mon, Jul 27, 2009 at 13:36, Brandon Savage<bran...@brandonsavage.net> wrote: > > > On Mon, Jul 27, 2009 at 7:28 AM, Hannes Magnusson > <hannes.magnus...@gmail.com> wrote: >> >> Don't top-post. >> >> On Mon, Jul 27, 2009 at 13:24, Brandon Savage<bran...@brandonsavage.net> >> wrote: >> > >> > On Mon, Jul 27, 2009 at 7:21 AM, Hannes Magnusson >> > <hannes.magnus...@gmail.com> wrote: >> >> >> >> Don't top-post :) >> >> >> >> On Mon, Jul 27, 2009 at 13:14, Brandon >> >> Savage<bran...@brandonsavage.net> >> >> wrote: >> >> > >> >> > On Mon, Jul 27, 2009 at 3:39 AM, Hannes Magnusson >> >> > <hannes.magnus...@gmail.com> wrote: >> >> >> >> >> >> On Sat, Jul 25, 2009 at 18:59, Brandon >> >> >> Savage<bran...@brandonsavage.net> >> >> >> wrote: >> >> >> > This is my first time submitting a patch, but I was asked to add >> >> >> > to >> >> >> > the >> >> >> > documentation and so here goes. >> >> >> > >> >> >> > Please let me know if I did anything incorrectly. >> >> >> >> >> >> We try to stay away from "you this" and "you that".. The >> >> >> documentations should be using 3rd person :] >> >> >> >> >> > I fixed those issues. Let me know if there are any others. >> >> > >> >> >> >> Function names should be wrapped in <function> elements, i.e. >> >> "<function>spl_autoload_register</function> allows.." >> >> >> > Done. >> > >> > Can we make a comprehensive list of anything else that's wrong so we can >> > avoid the back-and-forth? >> > >> >> () should not be used with <function>. The <function> element >> automatically generates those. >> <function> is also missing around __autoload. >> Lines should preferably not be longer then 80chars. >> >> Can't think of anything else. >> > > Alright. Characters limited to 80, and () removed. >
I'm unsure how the WS between <function> and the actual content of it will be handled, it will probably be trimmed away.. but it'll make grepping for <function>spl_autoload_register</function> a total nightmare. I'd recommend either break the 80chars limit "rule" or move <function> down to the new line too. -Hannes
