I have had a quick test and found a lot of it is working fine.. great work!

I did find my code breaks at these points:

1) The xml parser stops completely if it finds a doubly defined attribute like class="" and style="". Previously it would use just the last one defined.

The error reporting is great in that it tells me the source file the exact tag and the exact attribute it didnt like, however:

2) The srcLine of such errors is off. Look down about 8 lines and you will find it.

3) This strange line in the legacy code I inherited tries to define a values and display them:
<span tal:condition="php:col_name=='Office'"
tal:define="resp_office offices/${one_row/RESPONSIBLE_OFFICE} | false; resp_person loggedByList/${one_row/RESPONSIBLE_PERSON}/nameclipped | false">${resp_office} ${resp_person}</span>

Previously this gives a result like 'Houston Bob Smith' but now gives 'Houston 0 Bob Smith 0'

Some of those changes could break your templates, triggers, custom attributes, etc., so please test it, break it and report any bugs and incompatibilities!


PHPTAL mailing list

Reply via email to