[
https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562597#action_12562597
]
Utkarsh Srivastava commented on PIG-68:
---------------------------------------
Looks great.
Wouldn't it be better to leave a symlink in ${basedir} called pig.jar so that
it is easy to run. Plus existing scripts that assume that existence don't
break. That would also need to be deleted on clean.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser"
> folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when
> doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my
> opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
