[ 
https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566395#action_12566395
 ] 

Olga Natkovich commented on PIG-68:
-----------------------------------

I applied the patch to my tree and ran "ant clean" and it did not remove java 
files generated by javacc. I see that you have a pattern in clean that should 
remove them but it did not work in my case. Does it work for you?

I am using the following version of ant: Apache Ant version 1.6.5 compiled on 
June 2 2005.

> Improving build.xml in many ways :)
> -----------------------------------
>
>                 Key: PIG-68
>                 URL: https://issues.apache.org/jira/browse/PIG-68
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.1.0
>            Reporter: Benjamin Francisoud
>            Priority: Minor
>         Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, 
> build.xml-PIG-68-v03.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" 
> folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when 
> doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my 
> opinion)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to