[
https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566729#action_12566729
]
Olga Natkovich commented on PIG-68:
-----------------------------------
NodeGenerator is needed - without it the code does not compile. Also, clean
build does not compile. I think you need to also remove QueryParser.jj file in
thesrc/org/apache/pig/tools/pigscript/parser/ directory since it is generated.
Please, make sure that ant clean followed by ant builds successfully with your
next change and also that unit tests run, thanks.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch,
> build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser"
> folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when
> doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my
> opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
