[
https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Groschupf updated PIG-68:
--------------------------------
Attachment: build.xml-PIG-68-v06-SG.patch
Here is my contribution to this topic.
I basically completely rewrote the build.xml in a clean way based on the hadoop
build.xml.
The build.xml provides all functionality as before, plus
+ creating a pig and a pig-core.jar (as contributed by Iván de Prado).
+ creating a release tar ball - as hadoop
+ generate all sources into a separated folder for easy generation and removal.
+ improved configuration using build.properties
+ improved naming of jar files (version name)
+ improved java doc rendering
+ improved manifest file
+ improved formating
My patch does not use the svn revision number as Benjamin Francisoud verison
does.
In general I like the idea very much but from my pov should a revision number
only in "dev" jar name.
I guess it is possible to attach the revision number in case the version name
end on "-dev" but I had trouble to use ant conditions and string comparison.
Maybe a ant pro can help with this last little improvement.
> Improving build.xml in many ways :)
> -----------------------------------
>
> Key: PIG-68
> URL: https://issues.apache.org/jira/browse/PIG-68
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.1.0
> Reporter: Benjamin Francisoud
> Priority: Minor
> Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch,
> build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch,
> build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser"
> folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when
> doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my
> opinion)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
