[ 
https://issues.apache.org/jira/browse/PIG-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595199#action_12595199
 ] 

Pi Song commented on PIG-162:
-----------------------------

I'm too late. Other people already got the points.

This patch is really jumbo but I like the way it's been structured. The 
JobControl compiler looks good to me. This helps factor out complexity in the 
compilation pipeline where in this case performance is not something we're 
after.

The only comment here is that getWritableComparableTypes in DataType is Hadoop 
specific so it should be moved under hadoop backend package. Possibly we can 
create a new utility class for it.

PS. My experience trying to add another management thread in Map/Reduce was 
that if something went wrong your task process may not ever stop.

> Rework mapreduce submission and monitoring
> ------------------------------------------
>
>                 Key: PIG-162
>                 URL: https://issues.apache.org/jira/browse/PIG-162
>             Project: Pig
>          Issue Type: Sub-task
>         Environment: This bug tracks works to rework the submission and 
> monitoring interface to map reduce as described in  
> http://wiki.apache.org/pig/PigTypesFunctionalSpec
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>         Attachments: mapreduceJumbo.patch, mapreduceJumboWithComInc.patch, 
> split.png, TEST-org.apache.pig.test.TestMRCompiler.txt, 
> TEST-org.apache.pig.test.TestUnion.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to