[
https://issues.apache.org/jira/browse/PIG-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594731#action_12594731
]
Shravan Matthur Narayanamurthy commented on PIG-162:
----------------------------------------------------
Why is there a separate class for map only jobs?
[shrav] You are right the idea was to remove the if condition. I see what you
are saying. I think I can address that.
JobControlCompiler is walking the MR plan itself. Why doesn't it extend visitor
and depend on the visitor to do that for it instead? If it needs to walk the
tree in a distinctive way that could be encoded as another walker and used in
the visitor. It needs to be able to determine when it's found the top of the
list (there are not predecessors) so that it knows to create the JobControl
object and then start unrolling. But this can be done in a visitor.
[shrav] I thought that the visitor pattern would be an overkill and a lot of
unnecessary function calls.
Is Try1 a real test? It looks like it might have been a test you tried just to
make sure you could set up test stuff.
[shrav] It is not. My fault... I forgot to remove it.
Let's put the files GoldenFiles and InputFiles in
test/org/apache/pig/test/data. This will match the location that test input and
output files are already being placed in the main branch.
[shrav] ok
Many people are still using older style junit. Many of your unit tests don't
extend TestCase. This causes them to fail when I run them, because my version
of junit doesn't recognize them as tests...
[shrav] I am using 4.1 jUnit testing framework. Also the jUnit cookbook says
that to write a jUnit test case, I need to annotate the method with
@org.junit.Test and those tests should be run. The TestMRCompiler is failing
because, your jUnit is running anything that starts with test ignoring the
annotation info. Its probably an older version. The TestUnion is probably
failing because I did not provide a standard input file. I have used
/etc/passwd which is not right. I will change that.
> Rework mapreduce submission and monitoring
> ------------------------------------------
>
> Key: PIG-162
> URL: https://issues.apache.org/jira/browse/PIG-162
> Project: Pig
> Issue Type: Sub-task
> Environment: This bug tracks works to rework the submission and
> monitoring interface to map reduce as described in
> http://wiki.apache.org/pig/PigTypesFunctionalSpec
> Reporter: Alan Gates
> Assignee: Alan Gates
> Attachments: mapreduceJumbo.patch, split.png,
> TEST-org.apache.pig.test.TestMRCompiler.txt,
> TEST-org.apache.pig.test.TestUnion.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
