On 17.10.2016 22:33, Matt Turner wrote:
On Mon, Oct 17, 2016 at 12:54 PM, Samuel Pitoiset
<samuel.pitoi...@gmail.com> wrote:



On 10/17/2016 09:45 PM, Samuel Pitoiset wrote:

Thanks for fixing this.

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com>


Actually, we need to check for both ARB_compute_shader and
ARB_compute_variable_group_size since
https://cgit.freedesktop.org/mesa/mesa/commit/?id=8785a8ff8948385a913e9bd75e8cdd1092bd750f.

Strange. Shouldn't a [compute shader] section (or requiring
GL_ARB_compute_variable_group_size) be sufficient?

I'll make the change regardless.

They're slightly different things. Your patch made sure that the test is skipped when ARB_compute_variable_group_size isn't available. And it's true that for the [require] section, you actually don't need to explicitly check for ARB_compute_shader on top of that, because a driver that advertises ARB_compute_variable_group_size must also advertise ARB_compute_shader.

My patch was mostly about adding the `#extension GL_ARB_compute_shader: enable` to the shaders themselves. I've pushed that now as well.

Cheers,
Nicolai
_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to