-1 on url_utilities.jsp. You can do this very easily (and more efficiently) using the properties of the request, as I mentioned last week.
Other comments: - I'm not sure common_properties.jsp contains enough to justify separating it out into its own file. Additionally, the name of the file is misleading, since it implies that all JSPs in the www directory should include it, which is not the case (it only applies to JNLP files). At a minimum, the name of this file should be changed to common_properties.jnlp. - I would suggest renaming kitchen_sink-signed-customcolors.jnlp to kitchen_sink.custom_colors.jnlp (the signed is implied since you can't load a custom color scheme without it). - I would rename kitchen_sink-signed.jnlp to kitchen_sink.signed.jnlp, since this is more consistent with our JAR file naming conventions. Greg On Monday, October 12, 2009, at 01:05PM, "Sandro Martini" <[email protected]> wrote: >Hi to all, >I've just committed some little changes to enable jnlp write/rewrite >by jsp, for both demos and tutorials projects. > >Then, under demos I've added some files related to 3 different ways to >execute the "Kitchen Sink" Demo via Web Start: unsigned, signed, and >signed loading a custom colors file. > >There are also some jsp pages used to modularize all this stuff, and >also 2 other jnlp files to define only in one place pivot jars. > >Tomorrow I'll make other tests and link required files to the index >page, but the work I've submitted should work. >I've tried in Tomcat and Jetty (but outside pivot generated wars), and >all is Ok. > >Tell me what do you think, but please do not remove files. > > >One strange thing is that also with the signed jars, the version >loading custom color definitions, this doesn't work (could be a Web >Start Classloaders issue ...), and also Copy/Paste from outside >doesn't work. > >Oh, during build from sources (with Ant) I've seen a warning on signed >jars are expired ... this could be one of the problems I have. > >As always, comments / suggestions ? > > >Bye, >Sandro > >
