Hi Greg, > Sorry, I had missed that message - I assume you are referring to this: no problem. If there is a better way to do this,we can change it, but I'd prefer later, if/when needed.
> That makes sense. I would suggest common_jnlp.jsp. I would also suggest > moving the code from url_utilities.jsp to this file. Ok, I'd rename url_utilities.jsp to common_jnlp.jsp , but I'd keep two files separate because they are for different parts inside jnlp files. But for the moment I prefer to keep also the common_properties_for_jnlp.jsp file, at least until all this part is stable and more tested. > Again, I think this is too much. Any reasonable developer should be able to > extrapolate from your existing examples how this could be done. Ok. > Some additional comments on the code itself: > > - The formatting in url_utilities.jsp is not consistent with Pivot coding > standards: > - Do not vertically align variable declarations > - Do not insert a line break before an opening curly brace > - Always wrap if blocks in curly braces > - No leading indent necessary (same for common_properties_for_jnlp.jsp) > > - There are comments in some of the files that appear to contain debug code. > Unless you are actively developing this code, these should be removed. Ok, I'll fix all this stuff tomorrow ... or maybe today. Bye
