> -1 on url_utilities.jsp. You can do this very easily (and more efficiently) > using the properties of the request, as I mentioned last week. I'd be happy to do as you say, but it DOESN'T WORK HERE, I've tried yesterday (see one of my previous mails). To make it work I'd have later to change the Strings building in this way: for example removing the last part of the Path in URL and the last slash from the value for the href (because the href want only the file name of the current jnlp file for example), and put the last part of Path in codebase ... so I don't think it's a great improvement over my code. In any case, all this stuff is inside a dedicated jsp fragment, so code changes would be simpler. Comments ?
> - I'm not sure common_properties.jsp contains enough to justify separating it > out into its own file. Additionally, the name of the file is misleading, > since it implies that all JSPs in the www directory should include it, which > is not the case (it only applies to JNLP files). At a minimum, the name of > this file should be changed to common_properties.jnlp. I know I have created a solution more than needed, but my trouble is to give/show a solution that is ready to be used also in other (real) applications. Ok, but attention: other jnlp files (like pivot-runtime*) are real and valid jnlp files, while this if only a jsp fragment to not replicate code in all jnlp ... at the moment I've done jnlp files only for the "Kitchen Sink", but I have to do also for other Demos. What do you think on common_properties_for_jnlp.jsp ? > - I would suggest renaming kitchen_sink-signed-customcolors.jnlp to > kitchen_sink.custom_colors.jnlp (the signed is implied since you can't load a > custom color scheme without it). Ok. Only one question: also with signed jars the load of custom colors doesn't work, and also paste from clipboard (outside data copied inside doesn't work) ... ideas ? > - I would rename kitchen_sink-signed.jnlp to kitchen_sink.signed.jnlp, since > this is more consistent with our JAR file naming conventions. I try to avoid using multiple extensions on files, because for example on Windows this gives confusion, many times the last extension is not shown (is used for the showing the file type), and the other(s) goes in the file name, for example in File Managers. But Ok, for better consistency, also for pivot-runtime-signed.jnlp . Ah, I'm thinking to add also a pivot-runtime-all.jnlp (and maybe also the signed variant), including also the pivot-charts jar. What do you think ? And last, in current pivot-runtime*.jnlp is missing the pivot-web jar, it's not used in the "Kitchen Sink", but other use it, and it's a very little jar so i think it's Ok to add it also here. Thanks for the review. Sandro
