Hi,

On 02.05.2014 22:52, Scott Kitterman wrote:
On Friday, May 02, 2014 22:19:03 Andreas Cadhalpun wrote:
An upload to experimental seems like a good idea.
But keep in mind that experimental defaults to LLVM 3.4, while unstable
still defaults to LLVM 3.3 (and wheezy to LLVM 3.0).

Build-deps will only get pulled from Experimental if they aren't satisfied from
Unstable, so we can do it with 3.3 or 3.4 depending on what you want.

It's just that depending on llvm-dev (as I did) will result in 3.4 in experimental and in 3.3 in unstable. As this shouldn't matter, because it builds fine with both, I'm in favor of leaving the generic dependency, i.e. upload to experimental and build against 3.4 there and afterwards upload to unstable and build against 3.3.

More or less related to this, I found on [1]:
W implicit-declaration others.c:301

This can be trivially fixed by including the correct header (libxml/parser.h), see attached patch.
Now I'm unsure as to where to push this change?
To the unstable branch as 0009-*.patch, thus using the same number as for the LLVM patch, or to the aca_llvm branch as 0010-*.patch? I would tend to the latter and then both can be uploaded to experimental together.
Do you agree?

Best regards,
Andreas


1: http://qa.debian.org/bls/packages/c/clamav.html
diff --git a/libclamav/others.c b/libclamav/others.c
index 1cbc389..f52b9bd 100644
--- a/libclamav/others.c
+++ b/libclamav/others.c
@@ -72,6 +72,10 @@
 #include "bytecode_api_impl.h"
 #include "cache.h"
 
+#ifdef HAVE_LIBXML2
+#include "libxml/parser.h"
+#endif
+
 int (*cli_unrar_open)(int fd, const char *dirname, unrar_state_t *state);
 int (*cli_unrar_extract_next_prepare)(unrar_state_t *state, const char *dirname);
 int (*cli_unrar_extract_next)(unrar_state_t *state, const char *dirname);
_______________________________________________
Pkg-clamav-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-clamav-devel

Reply via email to