On Monday, August 11, 2014 23:48:24 Andreas Cadhalpun wrote: > Hi, > > On 10.08.2014 15:38, Sebastian Andrzej Siewior wrote: > > I just pushed the beta1 into the unstable branch. I have to run now and > > I try to add the libmspack later… > > The libmspack branch is already merged and I now added the systemd > patches. Do you intend to also merge the bigeasy branch for this upload? > > > Side note: I added > > > > |+++ b/debian/libclamav6.symbols > > |@@ -22,6 +22,7 @@ libclamav.so.6 libclamav6 #MINVER# > > |+ cl_engine_set_clcb_file_props@CLAMAV_PUBLIC 0.98.5~beta1+dfsg-1 > > | > > | cl_engine_set_clcb_hash@CLAMAV_PUBLIC 0.98.1 > > > > I remember that dfsg-1 was wrong and the debian version should go away. > > Yes, the debian revision should never appear in the symbols file. I > fixed that.
The way it is now, 0.98.5~beta1, is good. > > However I am uncomfortable adding 0.98.5 since it is not out (yet). > > Should we keep it as-is and string everything past 0.98.5 once it is > > out? > > Adding 0.98.5 wouldn't work, because it is larger than 0.98.5~beta1, but > having only this should be fine. Once the final release is made, we can > update that to 0.98.5, but we could just as well leave it as is. It's better to leave it, but it doesn't matter much either way. > Anyway it's good that we test this beta version, because I already found > a problem that should be fixed before the final release: there are a > number of implicit function declaration warnings: > scanners.c: In function 'cli_scanraw': > scanners.c:2109:25: warning: implicit declaration of function > 'cli_scanmscab' [-Wimplicit-function-declaration] > nret = cli_scanmscab(ctx, fpt->offset); > ^ > scanners.c:2614:17: warning: implicit declaration of function > 'cli_process_ooxml' [-Wimplicit-function-declaration] > ret = cli_process_ooxml(ctx); > ^ > scanners.c:2727:3: warning: implicit declaration of function > 'cli_scanmschm' [-Wimplicit-function-declaration] > ret = cli_scanmschm(ctx); > ^ > ooxml.c:464:21: warning: implicit declaration of function > 'unzip_single_internal' [-Wimplicit-function-declaration] > ret = unzip_single_internal(ctx, loff, ooxml_core_cb); > ^ Did you report this upstream? I tried building the current package and got test errors (here's an excerpt): ----------- SCAN SUMMARY ----------- Known viruses: 1 Engine version: 0.98.5-beta1 Scanned directories: 0 Scanned files: 46 Infected files: 43 Data scanned: 14.20 MB Data read: 6.91 MB (ratio 2.06:1) Time: 0.361 sec (0 m 0 s) *** *** clamscan didn't detect all testfiles correctly *** FAIL: check2_clamd.sh ===================== -------------------------------------- ... /tmp/buildd/clamav-0.98.5~beta1+dfsg/unit_tests/../test/clam.cab: OK /tmp/buildd/clamav-0.98.5~beta1+dfsg/unit_tests/../test/clam.chm: OK ... /tmp/buildd/clamav-0.98.5~beta1+dfsg/unit_tests/../test/clam_ISmsi_int.exe: OK ... I didn't see anything in configure that indicated we were missing something that we needed to detect these file types. Thoughts? Scott K _______________________________________________ Pkg-clamav-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-clamav-devel
