http://cr.opensolaris.org/~trevw/pkg-226/webrev/
These changes fix the two issues recorded in http://defect.opensolaris.org/bz/show_bug.cgi?id=226
- namely handling of requests for robots.txt and a bug in face.unknown().For the handling of robots.txt, I chose to return a file rather than hard-coding the content on the basis that administrators _may_ want to allow crawlers to attempt to crawl their pkg depot. The content of the checked-in file disallows crawling of the depot by default. I'd be happy to revise this if you guys think I'm on the wrong track. The only real problem I see in doing it this way is that the robots.txt file is located on PKG_ROOT/usr, which is probably not the best place for a file which could be edited by the admin.
The fix for the bug in face.unknown() was to remove the attempt at parameter substitution of request.headers because the parameter was not supplied in the preceding string. It looks like this should be the correct behaviour because the request headers are output in the previous line.
All feedback gratefully appreciated. Thanks, Trev
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
