On Mon, Nov 19, 2007 at 04:29:02PM +0000, Trevor Watson wrote: > http://cr.opensolaris.org/~trevw/pkg-226/webrev/
You should do the open() in a try/except clause to make sure that it actually succeeds, and return a 404 if appropriate. If you wanted to be super pedantic, I suppose you could even read the entire file in before sending the response code, in case that fails, but I'm not sure that's really worthwhile. The makefile change looks fine; can't comment on robots.txt itself. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
