On Thu 31 Jan 2008 at 08:25AM, Trevor Watson wrote:
> It looks like a neat and tidy solution to me Dan.

Great, thanks.  This is my first test suite, I'm just doing whatever
looks good.

What I'm finding is that while python unittest seems pretty good,
there are some things I found lacking compared to some other suites
I have used (example: tests can only pass or fail; there seems to
be no way to say "test not valid on this particular system")

I wonder if anyone has used anything better for python?  A little
googling did not find me too much, except for "testoob" which didn't
to be in widespread use.

> Just one minor nit on the example: I had to really think about what 
> 'UnexpectedReturnException' meant, and after looking through the code a 
> couple of times I think I got it - it's saying that the method return value 
> was not correct.

It's saying that the command line program we ran exited with an
exit code we didn't expect...

> I'm just wondering if there could be a more obvious name than 
> 'UnexpectedReturnException' - maybe 'WrongReturnValueException'?

I changed this to UnexpectedExitCodeException.  I tried it with
"Wrong" but to me it sort of seemed like it was trying to say
"the exit code is the thing that is wrong"-- whereas the problem
is really that the exit code we got is not the one we expected
to get.

Thanks for pointing this out, hopefully it is clearer now.

        -dp

-- 
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to