Dan Price wrote: <snip>
Just one minor nit on the example: I had to really think about what 'UnexpectedReturnException' meant, and after looking through the code a couple of times I think I got it - it's saying that the method return value was not correct.It's saying that the command line program we ran exited with an exit code we didn't expect...I'm just wondering if there could be a more obvious name than 'UnexpectedReturnException' - maybe 'WrongReturnValueException'?I changed this to UnexpectedExitCodeException. I tried it with "Wrong" but to me it sort of seemed like it was trying to say "the exit code is the thing that is wrong"-- whereas the problem is really that the exit code we got is not the one we expected to get. Thanks for pointing this out, hopefully it is clearer now.
Yep, thanks Dan - that's much more obvious now (to me, anyway). T.
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
