Looks nice. A couple things that come to mind:
- You don't seem to allow for tests whose expected failure can be
suppressed. I know we don't want to do that much, but when we're
coming up to a release, it'd be nice to have a "clean" run once we've
suppressed all non-stopper bugs.
- There's no check for expected output. We don't have a lot of places
where that's incredibly useful, but you'd want that in "pkg search",
and maybe some of the informational subcommands (info, list, status).
It might also be useful to check to make sure that an expected
exception occurred (rather than a different one, indicating a different
bug). Looks like from your second example that you do at least collect
the output, so it shouldn't be hard to finish the job.
- There's no way to check to see that something happened correctly on the
filesystem that can't be seen in return codes or a second command
(like, say, creating a Full image makes a var/pkg directory rather than
a .opensolaris.org directory). This would be useful both client and
server side.
- It might be useful to ensure that network operations are closed
forcefully if they appear to be hung.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
