Bart, > 470 pkg image-update can fail under some conditions. > http://cr.opensolaris.org/~barts/fixes-14/
In general this looks good. I like how you chose to fix the problem. Just a couple of nits: filelist.py:139 & 231 - Any chance you could combine the image.get_root() into the get_download_dir() function? You've also duplicated a call to os.getpid. It shows up on 139 and 231.o image.py:871 - Can image.root ever be empty? If you combine the get_root() into get_download_dir() I don't think you'll need to check self.root, or perform an os.path.join here. Thanks for fixing this. -j _______________________________________________ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
