On Feb 13, 2008 11:14 AM,  <[EMAIL PROTECTED]> wrote:
> Hi Shawn,
>
> This looks like a good start.
>
> > >The following webrev includes proposed fixes for the following bugs:
> > >
> > >       255 Symbolic HTTP response codes should be used
> > >       518 Some pkgsend tests fail due to -s parameter being unspecified
> > >
> > >http://cr.opensolaris.org/~swalker/pkg-255-518/
> >
> > Did you deliberately miss the symbolic codes for the 403 errors on (at
> > least) lines: 214, 235, 251, 267 ?
>
> Aside from Trevor's comment, I think there are still a bunch of other
> places where the code is using numeric return codes for HTTP.  Check
> out:
>
> src/modules/publish/transaction.py
> src/modules/client/image.py
> src/modules/misc.py
> src/modules/server/transaction.py
> src/modules/server/face.py

Sorry, that's what I get for looking for send_response.

I should have been looking for the response codes.

I'll take care of them tonight.

Cheers,
-- 
Shawn Walker, Software and Systems Analyst
http://binarycrusader.blogspot.com/

"To err is human -- and to blame it on a computer is even more so." -
Robert Orben
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to