Hi Shawn, This looks like a good start.
> >The following webrev includes proposed fixes for the following bugs: > > > > 255 Symbolic HTTP response codes should be used > > 518 Some pkgsend tests fail due to -s parameter being unspecified > > > >http://cr.opensolaris.org/~swalker/pkg-255-518/ > > Did you deliberately miss the symbolic codes for the 403 errors on (at > least) lines: 214, 235, 251, 267 ? Aside from Trevor's comment, I think there are still a bunch of other places where the code is using numeric return codes for HTTP. Check out: src/modules/publish/transaction.py src/modules/client/image.py src/modules/misc.py src/modules/server/transaction.py src/modules/server/face.py Thanks, -j _______________________________________________ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
