Brock, Thanks for taking a look at this, it's much appreciated. > filelist.py line 200 and image.py line 468, are the "pass" lines necessary?
IIUC, this isn't necessary since we're doing something in that block before the pass. I suspect it's there because I originally wrote an empty catch block and left the pass in when I modified the code. It does explicitly call out the fact that we're eating the exception, but if it's stylistically objectionable, I can take it out. > It looks like stat and shutil can be removed from the imports of filelist.py > The sames goes for retrieve in manifest.py Thanks for catching this. > Is there any reason that someone would want the number of timeouts > tolerated for fetching manifests versus fetching files to be different? They are the same variable, it's just that in filelist MAX_TIMEOUT_COUNT is imported explicitly, whereas all of misc is imported in image. At least right now, the timeouts are one and the same. Was there a case you're envisioning where we'd want to set these separately? -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
