Shawn, Thanks for taking a look at this.
> > http://cr.opensolaris.org/~johansen/pkg-timeout/ > > ========== > http://cr.opensolaris.org/~johansen/pkg-timeout/src/client.py.wdiff.html > > 1458 + print "Maximum number of timeouts exceeded > during download." > > Can you use the new msg() or emsg() method from pkg.misc to print this? Yes, I'll fix this. I forgot to do this when I merged. > ========== > http://cr.opensolaris.org/~johansen/pkg-timeout/src/modules/client/filelist.py.wdiff.html > > 216 + # Set the perms of the temporary file. The file > must > 217 + # be writable so that the mod time can be > changed on Windows > 218 + tarinfo.mode = 0600 > 219 + tarinfo.uname = "root" > 220 + tarinfo.gname = "root" > > Is this stil ok for a user image? It seems to work (I applied your > patch and tried it out). I'm not sure. There's functionally equivalent code in the previous version of this file. > =========== > http://cr.opensolaris.org/~johansen/pkg-timeout/src/modules/client/image.py.wdiff.html > > It looks like sys, types, and filelist are all unused imports. > > 1220 + print "Deleting content cache" > > Can you use the new msg() method from pkg.misc to print this? Yes, I forgot to do the msg() conversion when I merged. > =========== > http://cr.opensolaris.org/~johansen/pkg-timeout/src/modules/client/pkgplan.py.wdiff.html > > I'm somewhat hesitant to see file_0 go since it seems useful for a > "fix" command we might add. retreive:get_datastream() still exists so file_0 isn't gone completely. The changes to manifest.py and actions/license.py are the two changes we needed to stop using file_0 for downloads. It's still being used elsewhere for other slightly nefarious purposes. We can remove those later. Consider file_0 to be deprecated. It can still be used on the depot, but I'd like to get clients to stop using it. I'm still open to re-implementing file as a series of pipelined GETs later on down the road. > =========== > http://cr.opensolaris.org/~johansen/pkg-timeout/src/modules/manifest.py.wdiff.html > > 31 import pkg.client.retrieve as retrieve > > This isn't used. Thanks, I've removed it. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
