2008/6/10 <[EMAIL PROTECTED]>: > Folks, > Here's a set of fixes that address a number of bugs with the client > receiving a timeout while downloading packages. The webrev is available > on cr.opensolaris.org. > > http://cr.opensolaris.org/~johansen/pkg-timeout/
========== http://cr.opensolaris.org/~johansen/pkg-timeout/src/client.py.wdiff.html 1458 + print "Maximum number of timeouts exceeded during download." Can you use the new msg() or emsg() method from pkg.misc to print this? ========== http://cr.opensolaris.org/~johansen/pkg-timeout/src/modules/client/filelist.py.wdiff.html 216 + # Set the perms of the temporary file. The file must 217 + # be writable so that the mod time can be changed on Windows 218 + tarinfo.mode = 0600 219 + tarinfo.uname = "root" 220 + tarinfo.gname = "root" Is this stil ok for a user image? It seems to work (I applied your patch and tried it out). =========== http://cr.opensolaris.org/~johansen/pkg-timeout/src/modules/client/image.py.wdiff.html It looks like sys, types, and filelist are all unused imports. 1220 + print "Deleting content cache" Can you use the new msg() method from pkg.misc to print this? =========== http://cr.opensolaris.org/~johansen/pkg-timeout/src/modules/client/pkgplan.py.wdiff.html I'm somewhat hesitant to see file_0 go since it seems useful for a "fix" command we might add. Either way, this part looks fine. =========== http://cr.opensolaris.org/~johansen/pkg-timeout/src/modules/manifest.py.wdiff.html 31 import pkg.client.retrieve as retrieve This isn't used. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
