Hey Dan,
I took a look at your changes.  In general, I think this is good.

The only thought that I had was that you changed a bunch of code from
using datetime.datetime.now() to datetime.datetime.utcnow().  It would
probably make sense to make this consistent throughout the rest of the
code, so that we don't get weird/confusing behavior with timestamps and
time comparisons.  I think the catalog and updatelog use datetime, but
I'm not sure where else this shows up in the code.

Thanks,

-j

> Please look this over carefully.  I would like at least two reviewers.
> 
>    http://cr.opensolaris.org/~dp/fmri-perf

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to