2008/7/1 <[EMAIL PROTECTED]>: > Hey Dan, > I took a look at your changes. In general, I think this is good. > > The only thought that I had was that you changed a bunch of code from > using datetime.datetime.now() to datetime.datetime.utcnow(). It would > probably make sense to make this consistent throughout the rest of the > code, so that we don't get weird/confusing behavior with timestamps and > time comparisons. I think the catalog and updatelog use datetime, but > I'm not sure where else this shows up in the code.
Speaking of which... One of the things I ran into while working on bug 1324 (RSS/Atom feeds) is that some of the timestamps don't have a timezone, so I had to output timestamps with "Z". So, I'm glad to see this change if it will accomplish what I think it will. I plan on reviewing Dan's changes after work later tonight. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
