2008/7/1 Dan Price <[EMAIL PROTECTED]>: > On Tue 01 Jul 2008 at 02:46PM, Shawn Walker wrote: >> 2008/7/1 <[EMAIL PROTECTED]>: >> > Hey Dan, >> > I took a look at your changes. In general, I think this is good. >> > >> > The only thought that I had was that you changed a bunch of code from >> > using datetime.datetime.now() to datetime.datetime.utcnow(). It would >> > probably make sense to make this consistent throughout the rest of the >> > code, so that we don't get weird/confusing behavior with timestamps and >> > time comparisons. I think the catalog and updatelog use datetime, but >> > I'm not sure where else this shows up in the code. >> >> Speaking of which... >> >> One of the things I ran into while working on bug 1324 (RSS/Atom >> feeds) is that some of the timestamps don't have a timezone, so I had >> to output timestamps with "Z". >> >> So, I'm glad to see this change if it will accomplish what I think it will. >> >> I plan on reviewing Dan's changes after work later tonight. > > utcnow() does not appear to actually add a UTC timezone to the datetime. > I found the python docs for this stuff to be somewhat incomprehensible, > so I decided that I would just assume all datetimes were in UTC, and > take care to generate them in UTC.
I'm not certain about that. I believe I found local timestamps when I was working with the catalog for the RSS/Atom feeds. I'll look closer later tonight. Thanks, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
