On Wed 02 Jul 2008 at 02:56PM, Danek Duvall wrote:
> On Wed, Jul 02, 2008 at 02:46:01PM -0700, Dan Price wrote:
>
> > > version.py:
> > >
> > > - line 152: do you want to do any further semantic checking on the
> > > string? That is, months can't be greater than 12, etc?
> >
> > Sigh, that's a big problem. My concern is that it's going to be rather
> > expensive for all the checks we'll need to do. It may be that it winds
> > up being worth storing the timestamp as an integer, since we'll need to
> > pay the price to convert to ints during the validity checking.
>
> Yup. And conversion from integer to string isn't (or shouldn't be) that
> expensive.
Indeed.
> I think you can get rid of the build_release reference here, since we're
> pretty much not using it anywhere, and it doesn't really make much sense
> to have it here and not in __gt__ and __lt__. We can put it in again if
> it turns out to be necessary.
Ok, I'll look into it when I get back next week and finish up this work.
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
