On Tue, Jul 01, 2008 at 12:12:50AM -0700, Dan Price wrote:
> http://cr.opensolaris.org/~dp/fmri-perf
You need to expand your tabs.
version.py:
- line 43: extraneous ".". Or just cut line 44 entirely.
- line 152: do you want to do any further semantic checking on the
string? That is, months can't be greater than 12, etc?
- line 188: I'd pull the import out up to the top. Otherwise it will
(might?) get imported every time we execute get_timestamp(). Not that
this is very often, but still.
- line 263: What's magic about this? I don't entirely understand why
build_release is looked at here but not in __lt__ or __gt__, but that's
not magic, per se.>
t_version.py:
- line 71: It might be useful to compare dot sequences where the minor
number is the same but the major number isn't. You'd need a d7 for
this, I guess.
- In the same set, it might also be useful to test that d5 is not a
subsequence of d3.
- line 113: is this line testing __lt__ or __gt__? Similarly on line
130.
- line 136: Perhaps a test that two different version objects with the
same components test equal? Similarly in testversionne().
fmribench.py:
- line 224ff: remove?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
