On Tue 01 Jul 2008 at 09:09PM, Danek Duvall wrote:
> On Tue, Jul 01, 2008 at 12:12:50AM -0700, Dan Price wrote:
>
> > http://cr.opensolaris.org/~dp/fmri-perf
>
> You need to expand your tabs.
Yah, will do.
> version.py:
>
> - line 152: do you want to do any further semantic checking on the
> string? That is, months can't be greater than 12, etc?
Sigh, that's a big problem. My concern is that it's going to be rather
expensive for all the checks we'll need to do. It may be that it winds
up being worth storing the timestamp as an integer, since we'll need to
pay the price to convert to ints during the validity checking.
As an aside, this led me to discover that we blow up in an ugly way
today if you try to do e.g.:
pkg info pkg:/[EMAIL PROTECTED],5.11-0.91:20080613T999999Z
^^^^^^^
My code has the lucky side effect of letting us fail more gracefully,
but the cost is an overall decrease in safety. Thoughts?
> - line 263: What's magic about this? I don't entirely understand why
> build_release is looked at here but not in __lt__ or __gt__, but that's
> not magic, per se.>
I guess my point was: does anyone understand why build_release is referenced
here? I was not intending to check in the XXX, but rather to flag something
strange.
> t_version.py:
>
> - line 71: It might be useful to compare dot sequences where the minor
> number is the same but the major number isn't. You'd need a d7 for
> this, I guess.
Added.
> - In the same set, it might also be useful to test that d5 is not a
> subsequence of d3.
Added.
> - line 113: is this line testing __lt__ or __gt__? Similarly on line
> 130.
I reordered a little.
> - line 136: Perhaps a test that two different version objects with the
> same components test equal? Similarly in testversionne().
>
> fmribench.py:
>
> - line 224ff: remove?
Yah-- that's my memory usage estimator, I nuked it.
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
