On Fri, Jul 11, 2008 at 02:29:50PM -0700, Dan Price wrote:

> Should that exception handler be tighter?  Danek-- isn't this the sort
> of exception handler that gets us into trouble when someone does
> e.g. ctrl-c during an operation?

Yup.  But since all the surrounding exception handlers are doing exactly
the same thing, I wasn't going to bring (raise?) that up.  We're going to
want to do a bunch of exception cleanup in the code eventually.  Not sure
what the priority on that is.  Probably should be higher than it's likely
to be.  :-/

Also, at least in this case, bailing out of the function is exactly what
you'd want ^C to do.  So it ends up working out okay, I think.

> I was also wondering if this was going to confuse users if it just
> exits 0 and seems to do nothing.  Should it emit a message?

Yeah, that might be useful.  <shrug>

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to