> > Should that exception handler be tighter?  Danek-- isn't this the sort
> > of exception handler that gets us into trouble when someone does
> > e.g. ctrl-c during an operation?
> 
> Yup.  But since all the surrounding exception handlers are doing exactly
> the same thing, I wasn't going to bring (raise?) that up.  We're going to
> want to do a bunch of exception cleanup in the code eventually.  Not sure
> what the priority on that is.  Probably should be higher than it's likely
> to be.  :-/

Well, this is just a utility for capturing the contents of packages, so
you can move them around.  I would defer dealing with making the
exception handlers more specific until we have a reason to do so.

Most command-line utilities written in C have similar error handling:

        rc = syscall(args)
        if (rc < 0) {
                perror("syscall failed:")
                exit(EXIT_FAILURE)
        }

It's not clear that we need anything more sophisticated than that for
now.

-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to