On Fri, Jul 11, 2008 at 11:36:43PM -0500, Shawn Walker wrote: > > OK, Brock is right. The new webrev only calls fetch_files_byhash if > > content_hashes has a length > 0. > > > > Here's the link again: http://cr.opensolaris.org/~bgh/bug-2104/ > > http://cr.opensolaris.org/~bgh/bug-2104/src/pull.py.wdiff.html > ========== > 297 + print "No files to retrieve." > > All messages printed to the client should go through msg() emsg() or > error(). In this case, msg() is appropriate. > > While there are other places in this file that haven't been changed > yet, I'd like to see it start here. > > You just need to "from pkg.misc import msg" > > -- > Shawn Walker
OK, updated webrev. Is there already a bug filed to track offenders in this and other files? Thanks, Brad _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
