Danek Duvall wrote: > On Tue, Aug 05, 2008 at 12:55:06AM -0500, Shawn Walker wrote: > >> http://cr.opensolaris.org/~swalker/pkg-1324-6 > > depot.py: > > - line 129: why set opt here?
pylint warning > updatelog.py: > > - line 424: why not split(None, 2), and then you don't have to re-join on > line 429? Though actually, why do the split at all? Why not have > _gen_updates() yield the rich data structure, and then have > _send_updates() massage them into a single line? Having _gen_updates() yield the rich data structure would mean that _send_updates would simply have to redo what we already had to begin with. I've opted to instead use your suggestion for line 424 for the split. I have made all of the other changes you suggested. Thanks! -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
