Shawn Walker wrote: > Dan Price wrote: >> On Wed 30 Jul 2008 at 05:28PM, Shawn Walker wrote: >>> Shawn Walker wrote: >>>> I'm sending out a completely new review request for this wad as I have >>>> changed it significantly since the last webrev I sent out. The old >>>> versions are still available for comparison. >>>> >>>> The following webrev includes proposed fixes for the following bugs: >>>> >>>> 1324 RSS / Atom feeds of repository updates >>> original webrev: >>> http://cr.opensolaris.org/~swalker/pkg-1324/ >>> >>> previous webrev: >>> http://cr.opensolaris.org/~swalker/pkg-1324-4/ >>> >>> new webrev: >>> http://cr.opensolaris.org/~swalker/pkg-1324-5/ >>> >>> changes from last webrev: >>> http://cr.opensolaris.org/~swalker/pkg-1324-5/pkg-1324-4-5.patch >> Can you please update the 'pkg info' code to use your new >> bytes_to_str() routine? (And anything else that uses such measures?) >> It's OK to defer that to a followup putback, but it does need a bug >> filed against it. > > I filed: > 2761 ensure client has consistent output for units of measure > >> server/face.py: if head() is really supposed to return a >> common header for all pages, then I wouldn't think that the >> auto-feed-thingy should show up on every page... should it? > > My idea was that visiting any BUI page would show the RSS feed > subscription icon, so it was intentional. It makes little difference to > me if it only shows up on the index (status) page. > >> It would sort-of seem to lock us in to one feed per depot. >> Maybe I misunderstand how the code is supposed to work. > > I don't think it does, but I do intend the index page at the very least > to have it there so that users visiting a depot's main page will get a > subscription icon.
I've changed this only be output for the index page. I'm not concerned about the single feed item, it does not limit the user or us to a single feed. It just ensures that the "main feed" is easily subscribed to. >> repository.py: this may be a stupid question, but what's the >> logic behind wiring the feed to a specific server op rather than >> a face.py handler? > > No idea, it's what Stephen had originally, and it doesn't matter to me. This was bugging me too this week as I couldn't think of a reason why I would need to "version" the feed output as an operation. Thus, I've moved the handler for this into face.py which makes for cleaner initialization of our "BUI". New webrev: http://cr.opensolaris.org/~swalker/pkg-1324-6 Changes from last webrev: http://cr.opensolaris.org/~swalker/pkg-1324-6/pkg-1324-5-6.patch Is this ready for putback now? Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
