On Wed 30 Jul 2008 at 05:28PM, Shawn Walker wrote:
> Shawn Walker wrote:
> > I'm sending out a completely new review request for this wad as I have
> > changed it significantly since the last webrev I sent out. The old
> > versions are still available for comparison.
> >
> > The following webrev includes proposed fixes for the following bugs:
> >
> > 1324 RSS / Atom feeds of repository updates
>
> original webrev:
> http://cr.opensolaris.org/~swalker/pkg-1324/
>
> previous webrev:
> http://cr.opensolaris.org/~swalker/pkg-1324-4/
>
> new webrev:
> http://cr.opensolaris.org/~swalker/pkg-1324-5/
>
> changes from last webrev:
> http://cr.opensolaris.org/~swalker/pkg-1324-5/pkg-1324-4-5.patch
Can you please update the 'pkg info' code to use your new
bytes_to_str() routine? (And anything else that uses such measures?)
It's OK to defer that to a followup putback, but it does need a bug
filed against it.
server/face.py: if head() is really supposed to return a
common header for all pages, then I wouldn't think that the
auto-feed-thingy should show up on every page... should it?
It would sort-of seem to lock us in to one feed per depot.
Maybe I misunderstand how the code is supposed to work.
feed.py: 31: please distill this into a bug/RFE (if not done
already) then just omit 31-34.
200: XXX -- can you add that, or file a bug?
repositoryconfig.py: 129: why this change?
repository.py: this may be a stupid question, but what's the
logic behind wiring the feed to a specific server op rather than
a face.py handler? From what I can tell, each element of the feed will
contain a link to an 'info' URI, which causes the server to cough up
text/plain info about a given package. It seems odd for that to be a
non-HTML response, to me.
What's the impact on browsers of emitting a table with 10000 rows?
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
