Hi Dave,
I have gone through the installer changes,
please see my comments below.
Thank you,
Jan
perform_slim_install.c
======================
2134 td_safe_system(cmd, B_TRUE);
->
2134 td_safe_system(cmd, B_FALSE);
If B_TRUE is passed to td_safe_system(), it redirects
output of "cmd" in following way - stderr is captured in
/tmp/install_log and stdout is discarded:
# cmd 2>&1 1>/dev/null
Since the fix explicitly redirects both stdout & stderr
to /tmp/finish_log, td_safe_system() should be called with
B_FALSE.
install-finish
==============
334 #rm -rf ${BASEDIR}/save
I think the line could be removed (if we want to preserve
${BASEDIR}/save) or should be uncommented, if we would like
to get rid of "save" directory.
Dave Miner wrote:
> This is a request for review of a fairly complicated bundle of otherwise
> siple changes, addressing most of the lingering cruft on installed
> systems and some maintenance issues:
>
> 681 root as a role and "jack" user scheme doesn't work with IPS zones
> http://defect.opensolaris.org/bz/show_bug.cgi?id=681
>
> 1617 My hard drive isn't a CD, so why is slim_cd on there?
> http://defect.opensolaris.org/bz/show_bug.cgi?id=1617
>
> 1534 Cannot see highlight line in grub menu
> http://defect.opensolaris.org/bz/show_bug.cgi?id=1534
>
> 743 /etc/X11/gdm/custom.conf retains livecd customizations after
> install. http://defect.opensolaris.org/bz/show_bug.cgi?id=743
>
> 2901 install-finish is in the wrong package
> http://defect.opensolaris.org/bz/show_bug.cgi?id=2901
>
> These changes require mods across all of pkg, distro constructor, and
> the installer, so there are multiple webrevs:
>
> Installer:
> http://cr.opensolaris.org/~dminer/slim-681/
>
> Distro Constructor:
> http://cr.opensolaris.org/~dminer/dc-681/
>
> Pkg, for which there are two webrev's, since this includes initial
> population of the build 97 import directory so as not to pollute the
> delivered 96 import. The first webrev is similar to David's resync
> webrev's to show what's changing, while the second (-full) is the actual
> changes that will be pushed:
> http://cr.opensolaris.org/~dminer/pgate-681/
> http://cr.opensolaris.org/~dminer/pgate-681-full/
>
> Testing here has included multiple import runs of both slim and redist,
> builds of images, installs, and installation of ipkg zones.
>
> Review by David Comay is requested, others are certainly welcomed!
>
> Dave
> _______________________________________________
> pkg-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
