jan damborsky wrote:
> Hi Dave,
>
> I have gone through the installer changes,
> please see my comments below.
>
> Thank you,
> Jan
>
>
> perform_slim_install.c
> ======================
>
> 2134 td_safe_system(cmd, B_TRUE);
> ->
> 2134 td_safe_system(cmd, B_FALSE);
>
> If B_TRUE is passed to td_safe_system(), it redirects
> output of "cmd" in following way - stderr is captured in
> /tmp/install_log and stdout is discarded:
>
> # cmd 2>&1 1>/dev/null
>
> Since the fix explicitly redirects both stdout & stderr
> to /tmp/finish_log, td_safe_system() should be called with
> B_FALSE.
>
Right. Fixed.
>
> install-finish
> ==============
>
> 334 #rm -rf ${BASEDIR}/save
>
> I think the line could be removed (if we want to preserve
> ${BASEDIR}/save) or should be uncommented, if we would like
> to get rid of "save" directory.
>
Also fixed.
Dave
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
