Danek Duvall wrote: > On Fri, Sep 05, 2008 at 07:18:55PM -0700, Brock Pytlik wrote: > > >> http://cr.opensolaris.org/~bpytlik/ips-3039-v1/ >> > > query_engine.py: > > - line 63: This is potentially a slow operation, since it's checking the > contents of the two dictionaries for equivalence. You probably want to > use "is" instead of "==", or just test "n == 'fmri_hash'". > Ah, didn't realize the difference. Fixed now. > modules/indexer.py: > > - line 738: doesn't need continuation? > Right > search_errors.py: > > - line 37: Wouldn't you want the name of the file or the hash to be part > of the exception data? > Well, there's only file we're hashing on. I guess there's no reason not to have every exception raised with "full_fmri_list.hash" as an argument, but I also can't see a good reason to do it that way. I had originally included the hash (both hashes actually, the expected on and the actual one). Then I decided that there was little value in telling the user (or anyone or any code) that the hash was one thing instead of another since I couldn't think of anything to do with that information. I'm certainly open to the suggestion that I'm wrong about that.
Thanks for the feedback. Unless I hear other objections, I'm going to resync with the gate and then push this back either today or tomorrow. Brock > Danek > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
