On Fri, Sep 05, 2008 at 07:18:55PM -0700, Brock Pytlik wrote:
> http://cr.opensolaris.org/~bpytlik/ips-3039-v1/
query_engine.py:
- line 63: This is potentially a slow operation, since it's checking the
contents of the two dictionaries for equivalence. You probably want to
use "is" instead of "==", or just test "n == 'fmri_hash'".
modules/indexer.py:
- line 738: doesn't need continuation?
search_errors.py:
- line 37: Wouldn't you want the name of the file or the hash to be part
of the exception data?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
