On Mon, Sep 08, 2008 at 04:23:07PM -0700, Brock Pytlik wrote:

>> search_errors.py:
>>
>>   - line 37: Wouldn't you want the name of the file or the hash to be part
>>     of the exception data?
>>   
> Well, there's only file we're hashing on. I guess there's no reason not to 
> have every exception raised with "full_fmri_list.hash" as an argument, but 
> I also can't see a good reason to do it that way. I had originally included 
> the hash (both hashes actually, the expected on and the actual one). Then I 
> decided that there was little value in telling the user (or anyone or any 
> code) that the hash was one thing instead of another since I couldn't think 
> of anything to do with that information. I'm certainly open to the 
> suggestion that I'm wrong about that.

If there's nothing useful to be done with the information, then by all
means, leave it out.  I just wasn't sure if that was the case or not.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to