On Thu 25 Sep 2008 at 05:48PM, Brock Pytlik wrote:
> Webrev:
> http://cr.opensolaris.org/~bpytlik/ips-1651/
>
> Bug:
> pkg treats -R <bogus-dir> as "use the image at /"
> http://defect.opensolaris.org/bz/show_bug.cgi?id=1651
>
> Short change, 3 lines in client.py, and some new tests to make sure it
> works.
I think using_ is sort of redundant. inferred_image_dir would
be sufficient.
I think the messaging could be better and need not involve the
discovered image. I would suggest instead:
$ pkg -R /tmp/foo install bar
pkg: No image rooted at '/tmp/foo'
$ PKG_IMAGE=/tmp/foo pkg install bar
pkg: No image rooted at '/tmp/foo' (set by $PKG_IMAGE)
Thanks,
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
