On Fri, Sep 26, 2008 at 04:02:59PM -0700, Brock Pytlik wrote:
> http://cr.opensolaris.org/~bpytlik/ips-1651-v3/
image.py:
- line 103: I'd just call this "ImageNotFoundException". More fully, I'd
add a boolean member to it called "specified", setting it to true when
you raise it where you do now, and replace the ValueError we're
currently raising with an ImageNotFoundException where "specified" was
False, and possibly combine the messaging around the two when caught.
- line 104: "an" -> "a"
- line 223: update the comment to reflect introduction of exact_match
- line 253-255: what's this third test for? Also, binary operators
should be at the end of a line, not the beginning.
client.py:
- line 2110: isn't this always going to be "mydir"? Why keep this in the
exception? And I don't see you using the other two members, either.
t_R_option.py:
- I don't think you're using "os", "time", or "stat" imports.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
