Brock Pytlik wrote:
> New webrev which moves the logic into find_root and I hope changes the 
> GUI appropriately.
> http://cr.opensolaris.org/~bpytlik/ips-1651-v2/

image.py:
   line 104: docstring please

   line 252: space needed after ','

packagemanager.py:
   lines 1199ff: since you changed this, can you change the ' to " for 
the strings and s/not valid/not a valid/ ?

   line 1209: s/is not None// simpler?

Otherwise, looks fine.

Cheers,
-- 
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to