On Sat, Sep 27, 2008 at 05:10:23PM -0700, Danek Duvall wrote: > On Fri, Sep 26, 2008 at 10:44:38AM -0700, Brad Hall wrote: > > > http://cr.opensolaris.org/~bhall/bug-3588/ > > client.py: > > - you need to update the usage message > > - with line 1897, you should now be using image_dir in place of pargs[0] > further on (line 1913, 1917, etc). > > - line 1903: I'm not sure this is right -- find_root does an upward > search for an image, but that's not the behavior you want here. If I > ask to create an image at "/etc", then I actually want to create it at > "/etc", even if that directory exists (but not if it's already an image > root). The way you have it now, it'll discover that "/etc" is a part > of the image rooted at "/" and require the force flag. > > Danek
Ok, new webrev: http://cr.opensolaris.org/~bhall/bug-3588-2/ - Removed the findroot check; took some pieces from image::find_root and moved them into another function which we're using for the check (determines the image type at a given spot) - pargs[0] -> image_dir - added test for -f option Thanks, Brad _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
