Brad Hall wrote:
> On Wed, Oct 01, 2008 at 03:25:09PM -0700, Dan Price wrote:
>> On Wed 01 Oct 2008 at 03:16PM, Danek Duvall wrote:
>>> On Tue, Sep 30, 2008 at 04:23:11PM -0700, Brad Hall wrote:
>>>
>>>> Ok, new webrev: http://cr.opensolaris.org/~bhall/bug-3588-2/
>>> Looks fine to me.
>> Since there's been some change in some of the areas you are touching,
>> could you merge up and repost?
>
> Sorry, I thought I had done that already.. guess not. Here is the merged
> webrev: http://cr.opensolaris.org/~bhall/bug-3588-3/
client.py:
line 1981: _("WARNING: there is already an image at: %s" %
image_dir)) -- you don't want the path to be passed to _(), so you
probably need to move the next to last ')' right after the ".
lines 1978, 1980: since 'found' is only used on line 1978, why not
move the comparison to line 1980 and drop the un-needed variable?
Otherwise, looks fine.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
