On Tue 07 Oct 2008 at 02:46PM, Brad Hall wrote:
> > A related question: if the specified directory exists, but has other
> > non-image junk in it, what should we do?
>
> Sounds like we should error in that case, too.
>
> New webrev up addressing these points and sync'd with the gate:
> http://cr.opensolaris.org/~bhall/bug-3588-5/
I think this wants to say:
"Non-empty directory: %s" -- the problem is not the existence of
the dir, but the contents within it...
I think you should also add a test case:
- Make a dir
- Touch a file in it
- Try to make an image in that dir
Just fix those two things and get it in. I don't feel a need to
review this again.
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
